search

secondlife / jira-archive

2 stars 0 forks source link

[BUG-10434] Unable to texture meshes with spaces in the material names on the Importer viewer. #762

Open sl-service-account opened 9 years ago

sl-service-account commented 9 years ago

Not sure if this is a bug or an expected behaviour change on the Importer viewer.

Steps to Reproduce

TestMesh_2Mat_with_spaces

TestMesh_2Mat_no_spaces

Attachments

Links

Duplicates

Original Jira Fields | Field | Value | | ------------- | ------------- | | Issue | BUG-10434 | | Summary | Unable to texture meshes with spaces in the material names on the Importer viewer. | | Type | Bug | | Priority | Unset | | Status | Been Triaged | | Resolution | Triaged | | Reporter | Whirly Fizzle (whirly.fizzle) | | Created at | 2015-10-08T07:23:10Z | | Updated at | 2017-05-08T22:47:41Z | ``` { 'Business Unit': ['Platform'], 'Date of First Response': '2015-10-08T13:14:51.274-0500', "Is there anything you'd like to add?": 'Does not reproduce on pre-importer viewer versions.', 'ReOpened Count': 0.0, 'Severity': 'Unset', 'System': 'SL Viewer', 'Target Viewer Version': 'viewer-development', 'What just happened?': '...', 'What were you doing when it happened?': 'Filling in...', 'What were you expecting to happen instead?': '...', } ```
sl-service-account commented 9 years ago

Kyle Linden commented at 2015-10-08T18:14:51Z

Duplicates MAINT-5678 Thanks!

sl-service-account commented 8 years ago

Whirly Fizzle commented at 2015-11-23T23:17:41Z, updated at 2015-11-23T23:28:18Z

This bug is listed as fixed on the Maint-RC: http://wiki.secondlife.com/wiki/Release_Notes/Second_Life_Release/3.8.7.308081 MAINT-5678 [Importer] materials with spaces in name import with truncated names https://bitbucket.org/lindenlab/viewer-bear/commits/de52f1d38f3c9b27d937d27ebce8e94736a25117

However it still reproduces for me on that viewer.

Enabling ImporterDebug shows the material names containing spaces are still getting truncated.

sl-service-account commented 8 years ago

Whirly Fizzle commented at 2015-11-25T22:05:37Z

I tested importing the 8squares_test.DAE attached to BUG-10783 on the Maint-RC viewer too. This dae has spaces in the material names and the material names are still truncated on upload and the imported mesh has broken faces.

sl-service-account commented 8 years ago

Whirly Fizzle commented at 2015-12-16T02:41:43Z

New fixes lurking in Lion:

sl-service-account commented 8 years ago

Whirly Fizzle commented at 2015-12-16T06:50:05Z

Testing on http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/maint_viewer-lion/rev/309168/index.html, which is built at rev 9c9c9d51352e & includes the new fixes above.

This bug is fixed for my repro dae attached to this issue and also fixed for the dae attached to BUG-10783. However there is a new crash when uploading mesh on this Lion build.

When ImporterLegacyMatching is set to TRUE, the viewer will crash when uploading most meshes. This crash does not reproduce on default release.

Both dae files attached to this issue will crash the Lion build when ImporterLegacyMatching is set to TRUE.

Whirly_1_logs attached.

Callstack:

Operating system: Windows NT
                  6.1.7601 Service Pack 1
CPU: x86
     GenuineIntel family 6 model 60 stepping 3
     8 CPUs

Crash reason:  EXCEPTION_ACCESS_VIOLATION_READ
Crash address: 0xc8
Assertion: Unknown assertion type 0x00000000
Process uptime: 96 seconds

Thread 0 (crashed)
 0  SecondLifeTest.exe!LLModel::isMaterialListSubset(LLModel *) [llmodel.cpp : 1232 + 0x0]

 1  SecondLifeTest.exe!LLModel::matchMaterialOrder(LLModel *,int &,int &) [llmodel.cpp : 1284 + 0x9]

 2  SecondLifeTest.exe!LLModelPreview::updateStatusMessages() [llfloatermodelpreview.cpp : 2628 + 0x2f]

 3  SecondLifeTest.exe!boost::function5<void,float,float,float,float,float>::operator()(float,float,float,float,float) [function_template.hpp : 767 + 0x45]

 4  SecondLifeTest.exe!boost::detail::variant::visitation_impl<boost::mpl::int_<0>,boost::detail::variant::visitation_impl_step<boost::mpl::l_iter<boost::mpl::l_item<boost::mpl::long_<2>,boost::shared_ptr<void>,boost::mpl::l_item<boost::mpl::long_<1>,boost::signals2::detail::foreign_void_shared_ptr,boost::mpl::l_end> > >,boost::mpl::l_iter<boost::mpl::l_end> >,boost::detail::variant::destroyer,void *,boost::variant<boost::shared_ptr<void>,boost::signals2::detail::foreign_void_shared_ptr,boost::detail::variant::void_,boost::detail::variant::void_,boost::detail::variant::void_,boost::detail::variant::void_,boost::detail::variant::void_,boost::detail::variant::void_,boost::detail::variant::void_,boost::detail::variant::void_,boost::detail::variant::void_,boost::detail::variant::void_,boost::detail::variant::void_,boost::detail::variant::void_,boost::detail::variant::void_,boost::detail::variant::void_,boost::detail::variant::void_,boost::detail::variant::void_,boost::detail::variant::void_,boost::detail::variant::void_>::has_fallback_type_>(int,int,boost::detail::variant::destroyer &,void *,boost::mpl::bool_<0>,boost::variant<boost::shared_ptr<void>,boost::signals2::detail::foreign_void_shared_ptr,boost::detail::variant::void_,boost::detail::variant::void_,boost::detail::variant::void_,boost::detail::variant::void_,boost::detail::variant::void_,boost::detail::variant::void_,boost::detail::variant::void_,boost::detail::variant::void_,boost::detail::variant::void_,boost::detail::variant::void_,boost::detail::variant::void_,boost::detail::variant::void_,boost::detail::variant::void_,boost::detail::variant::void_,boost::detail::variant::void_,boost::detail::variant::void_,boost::detail::variant::void_,boost::detail::variant::void_>::has_fallback_type_,boost::mpl::int_<0> *,boost::detail::variant::visitation_impl_step<boost::mpl::l_iter<boost::mpl::l_item<boost::mpl::long_<2>,boost::shared_ptr<void>,boost::mpl::l_item<boost::mpl::long_<1>,boost::signals2::detail::foreign_void_shared_ptr,boost::mpl::l_end> > >,boost::mpl::l_iter<boost::mpl::l_end> > *) [visitation_impl.hpp : 237 + 0x17]

 5  SecondLifeTest.exe!boost::signals2::detail::signal_impl<void ,boost::signals2::optional_last_value<void>,int,std::less<int>,boost::function<void >,boost::function<void >,boost::signals2::mutex>::operator()(float,float,float,float,float) [signal_template.hpp : 246 + 0xaf]
Second Life 3.8.7 (309168) Dec 15 2015 03:29:22 (Second Life Test)
Release Notes

CPU: Intel(R) Core(TM) i7-4770K CPU @ 3.50GHz (3491.92 MHz)
Memory: 16268 MB
OS Version: Microsoft Windows 7 64-bit Service Pack 1 (Build 7601)
Graphics Card Vendor: NVIDIA Corporation
Graphics Card: GeForce GTX 750/PCIe/SSE2

Windows Graphics Driver Version: 10.18.0013.5906
OpenGL Version: 4.5.0 NVIDIA 359.06

libcurl Version: libcurl/7.38.0 OpenSSL/1.0.1h zlib/1.2.8
J2C Decoder Version: KDU v7.2
Audio Driver Version: FMOD Ex 4.44.31
Qt Webkit Version: 4.7.1 (version number hard-coded)
Voice Server Version: Not Connected
Built with MSVC version 1800
sl-service-account commented 8 years ago

Whirly Fizzle commented at 2016-02-21T16:25:31Z

This is fixed on the MAINT-RC: http://wiki.secondlife.com/wiki/Release_Notes/Second_Life_Release/4.0.2.310545

I filed a seperate issue for the crash: BUG-11437