[BUG-230049] Stars render around center of sim instead of center of camera.

[sl-service-account]

What just happened?

Noticed the stars were not being transformed by the camera origin coords and were rendering at the sim origin point.

What were you doing when it happened?

Staring at the sky at extremely weird camera angles and heights.

What were you expecting to happen instead?

For the starts to be transformed by the camera origin so as to render around the point the camera is at and not the center of the sim.

Other information

For contribution of https://bitbucket.org/RyeMutt/starscream/commits/93f8dcafec46053b724c7347f82da104a7d75219

Original Jira Fields

| Field | Value | | ------------- | ------------- | | Issue | BUG-230049 | | Summary | Stars render around center of sim instead of center of camera. | | Type | Bug | | Priority | Unset | | Status | Closed | | Resolution | Triaged | | Labels | whirly-eep | | Created at | 2021-01-14T21:43:30Z | | Updated at | 2021-06-07T17:42:58Z | ``` { 'Build Id': 'unset', 'Business Unit': ['Platform'], 'Date of First Response': '2021-01-14T16:23:02.494-0600', "Is there anything you'd like to add?": 'For contribution of https://bitbucket.org/RyeMutt/starscream/commits/93f8dcafec46053b724c7347f82da104a7d75219', 'ReOpened Count': 0.0, 'Severity': 'Unset', 'System': 'SL Viewer', 'Target Viewer Version': 'viewer-development', 'What just happened?': 'Noticed the stars were not being transformed by the camera origin coords and were rendering at the sim origin point.', 'What were you doing when it happened?': 'Staring at the sky at extremely weird camera angles and heights.', 'What were you expecting to happen instead?': 'For the starts to be transformed by the camera origin so as to render around the point the camera is at and not the center of the sim.', } ```

[sl-service-account]

sovereign.engineer commented at 2021-01-14T21:58:27Z

Here's a video demonstrating the issue since reproducing requires modifying the camera to have no max distance clamping.

 

https://drive.google.com/uc?id=1Z-DNlV1iCHkZeDURHTH05xHqL8mGHe_R

[sl-service-account]

Ptolemy Linden commented at 2021-01-14T22:23:02Z

Some more info. on this issue:

SL viewer clamps the distance in llagentcamera.cpp

TPV don't, due to disabling camera restraints, which effectively makes this INT_MAX and exposes this bug. (The above video makes it obvious that the stars are not centered around the camera.)

[sl-service-account]

Dan Linden commented at 2021-01-16T00:10:45Z

Thank you for the contribution, Sovereign!