[BUG-10696] Facial expressions & "Preview while..." not working in many languages when importing animations

[sl-service-account]

• In most language translations, both the facial expression and the Preview While... selectors are broken in the BVH upload floater.

• Spanish 'es' has no animation floater xml at all so falls back to using the default English version and does not reproduce the bug.

• German 'de', Italian 'it', Japanese 'ja', Portuguese 'pt', Russian 'ru', Turkish 'tr' and Chinese 'zh' all reproduce the bug.

• The combobox items normally have three attributes:

  • label - The 'label' attribute is the user-visible one.
  • name - The 'name' attribute uniquely identifies the item, and must be present even in translations.
  • value - The 'value' attribute is what the code uses for its internal handling.

• Most translations have translated strings for the 'value' attribute. That is wrong, and confuses the code.

• The correct thing to do is to not specify a 'value' attribute, so that it's value is inherited from the one with the same 'name' attribute in the default English version.

• For that reason, only the facial expression 'Aaaaah' works in some translations because it's untranslated, and does not work in 'ja' 'ru' and 'zh' because it's translated.

  Steps to Reproduce

• Lets use the Russian language for detailed steps to reproduce the problem.

• Go to Me -> Avatar -> Preferences -> General -> Set Language to Russian and relog.

• Go to Build -> Upload -> Animation - See Fig 1 attached if your Russian sucks.

• Choose any bvh file - I attached a sample bvh to this issue.

• See Fig 2 attached.

• In the animation preview floater, go to "Preview While..." and check the Walking, Sitting & Flying options.

• Set "Preview while..." back to Standing (the top option).

• Set Expression to Aaaaax.

• Upload the animation and play it.

  Observed Behaviour

"Preview While..."

• When Preview while is set to Walking, Sitting, Flying, the dummy avatar does not play these animations. It remains showing preview while standing.
• See Fig 3 attached.

Facial Expressions

• When the animation is played after upload, there is no Aaaaah facial animation played.

• See Fig 5 attached.

  Expected Behaviour

"Preview While..."

• When Preview while is set to Walking, Sitting, Flying, the dummy avatar should play the Walking, Sitting, Flying animations. It remains showing preview while standing.
• See Fig 4 attached which shows the expected behaviour when the viewer is set to English.

Facial Expressions

• When the animation is played after upload, the Aaaaah facial animation should play.

• See Fig 6 attached which shows the expected behaviour when the viewer is set to English.

  Other Information.

  Does the viewer really have to force a full cache clear every time you change language? Is it supposed to do that? Because of BUG-10703, I gained over 3000 extra duplicated calling cards (337 friends, 10 cache clears).

  ETA: Looks like it's expected behaviour as the fix for VWR-22633 "To get rid of obsolete translations I clear all caches whenever viewer language gets changed." sulks

Attachments

• avatar_blowkiss.bvh 2015-11-15 04:37:46
• Fig 1.png 2015-11-15 04:36:56
• Fig 2.png 2015-11-15 04:36:56
• Fig 3.gif 2015-11-15 04:55:09
• Fig 4.gif 2015-11-15 04:55:09
• Fig 5.gif 2015-11-15 04:55:09
• Fig 6.gif 2015-11-15 04:55:09

Original Jira Fields

| Field | Value | | ------------- | ------------- | | Issue | BUG-10696 | | Summary | Facial expressions & "Preview while..." not working in many languages when importing animations | | Type | Bug | | Priority | Unset | | Status | Accepted | | Resolution | Accepted | | Reporter | Whirly Fizzle (whirly.fizzle) | | Created at | 2015-11-14T01:23:23Z | | Updated at | 2017-05-08T22:56:12Z | ``` { 'Business Unit': ['Platform'], 'Date of First Response': '2015-11-17T11:59:44.601-0600', 'ReOpened Count': 0.0, 'Severity': 'Unset', 'System': 'SL Viewer', 'Target Viewer Version': 'viewer-development', 'What just happened?': '...', 'What were you doing when it happened?': 'Filling in...', 'What were you expecting to happen instead?': '...', } ```

[sl-service-account]

Grumpity Linden commented at 2015-11-17T17:59:45Z

we should implement a better way to get rid of obsolete translations.

[sl-service-account]

Whirly Fizzle commented at 2015-11-22T19:56:02Z

This is fixed on http://wiki.secondlife.com/wiki/Release_Notes/Second_Life_Release/3.8.7.308081