search

secondlife / viewer

🖥️ Second Life's official client
GNU Lesser General Public License v2.1
206 stars 52 forks source link

Add tool to "Show Mirror Volumes" #1042

Open Dan-Linden opened 5 months ago

Dan-Linden commented 5 months ago

Environment

Second Life Release 7.1.4.8329357019 (64bit) Release Notes

You are at 169.0, 48.8, 24.2 in Rumpus Room 2048 located at simhost-01129fe6e38889eb3.aditi SLURL: secondlife://Aditi/secondlife/Rumpus%20Room%202048/169/49/24 (global coordinates 36,521.0, 14,128.8, 24.2) PMFP 2024-02-08.7835620080 Release Notes

CPU: Intel(R) Core(TM) i7-5930K CPU @ 3.50GHz (3491.92 MHz) Memory: 32610 MB OS Version: Microsoft Windows 10 64-bit (Build 19045.4170) Graphics Card Vendor: NVIDIA Corporation Graphics Card: NVIDIA GeForce GTX 1080/PCIe/SSE2

Windows Graphics Driver Version: 31.0.15.3623 OpenGL Version: 4.6.0 NVIDIA 536.23

Window size: 1645x1264 Font Size Adjustment: 96pt UI Scaling: 1 Draw distance: 128m Bandwidth: 3000kbit/s LOD factor: 1.75 Render quality: 5 Texture memory: 7304MB Disk cache: Max size 1638.4 MB (25.8% used)

J2C Decoder Version: KDU v7.10.4 Audio Driver Version: FMOD Studio 2.02.13 Dullahan: 1.14.0.202310131404 CEF: 118.4.1+g3dd6078+chromium-118.0.5993.54 Chromium: 118.0.5993.54 LibVLC Version: 3.0.16 Voice Server Version: Vivox 4.10.0000.32327.5fc3fe7c.399bd0e

Packets Lost: 0/4,734 (0.0%) March 25 2024 09:39:29

Description

Add some way to show Mirror Volumes. Either show them when "Show Reflection Probe Volumes" are enabled or add a new "Show Mirror Volumes" option to Build > Options. Put this behind the MirrorsEnabled Feature flag if that's the correct thing to do.

Reproduction steps

  1. Make a Mirror Volume
  2. Enable Build > Options > Show Reflection Probe Volumes

Observed: The Mirror Volumes are not highlighted.

maestrolinden commented 4 months ago

In the 7.1.6.8727446379 viewer against server 2024-04-13.8669470296 (mirrors enabled in SimulatorFeatures), I'm seeing some squirrelly behavior which might be caused by this bug. My workflow looks like this:

  1. Enable "Show reflection probe volumes" and "Select reflection probes" in viewer options
  2. Rez a box, set it to a box-type of with probe update set to "mirror"
  3. Observe that the probe is highlighted as yellow
  4. Carefully place the probe in a room with shiny surfaces
  5. Observe that the probe is making the intended effect (e.g. if in an enclosed room, the ceiling appears in reflections rather than the sky)
  6. Toggle "Show reflection probe volumes" off & on a few times to in order to tweak the placement and note the scene lighting each time
  7. Satisfied with the probe, exit the viewer
  8. Launch a new viewer session and visit last location
  9. Observe that the probe does not affect scene lighting in the new session
  10. Enable "Show reflection probe volumes". Observe that the mirror probe does not render (but others do)
  11. Observe that the probe hasn't been by accident derezzed - it's visible in the list in Pathfinding Tools -> Region Objects
kylelinden commented 4 months ago

Let's find out if priority High gltf dev issues get traction!