search

secondlife / viewer

🖥️ Second Life's official client
GNU Lesser General Public License v2.1
211 stars 53 forks source link

Add GLTFEnabled to SimulatorFeatures #1129

Closed RunitaiLinden closed 2 months ago

RunitaiLinden commented 7 months ago

This will act as the feature flag for enabling GLTF Scene drag/drop (#1128)

When connected to GLTF enabled regions (i.e. PMFP channel on aditi), Develop->GLTF->Open should be enabled. Otherwise it should be disabled.

RunitaiLinden commented 5 months ago

Viewer side integrated to GLTF Dev

Server side waiting on https://github.com/secondlife/server/pull/1020

AtlasLinden commented 3 months ago

Regions on Aditi using PMFP channels include Rumpus Room 1-4 and 2048-2051

DmitrySProductengine commented 3 months ago

Deferred QA. Verified on the Second Life Release 7.1.9.9865199239 (64bit) on Win10/OSX in the scope of IQA #282.

Tested on Aditi:

  1. PMFP - Rumpus Room 2048 (PMFP 2024-06-25.9663125755).
  2. SLS - Product Engine Trunk (Second Life Server 2024-06-11.9458617693).
  3. WebRTC - webRTC1 (WebRTC-Voice 2024-06-24.9652733849).

In all regions (not just PMFP), the new feature was enabled (Open was available). Theoretically, it is possible that PMFP (GLTF-enabled regions) has already been added to SLS regions and this behavior is expected. This ticket does not indicate the exact criteria (or examples) of regions where the new feature should be disabled.

But there is also a difference in the behavior of this new feature on different simulators:

  1. This feature is active on the SLS simulator, allowing you to open GLTF, but the “Save As” and “Upload” functions are inactive.
  2. On the PMFP simulator, all 3 functions are active - “Open”, “Save as” and “Upload”.

Due to the described difference in behavior and due to the difficulty of determining the regions where the feature should be disabled, this issue was moved to the Needs info. Perhaps this behavior is erroneous and the ticket needs to be reopened.

See attached screenshots:

  1. 7.1.9.9865199239 - Aditi - PMFP - all 3 functions enabled

    7 1 9 9865199239 - Aditi - PMFP - all 3 functions enabled

  2. 7.1.9.9865199239 - Aditi - SLS - only Open enabled

    7 1 9 9865199239 - Aditi - SLS - only Open enabled

  3. 7.1.9.9865199239 - Aditi - WebRTC - only Open enabled

    7 1 9 9865199239 - Aditi - WebRTC - only Open enabled

A new crash bug was also issued when trying to open a test GLTF with 2k textures - https://github.com/secondlife/viewer/issues/2041.

AtlasLinden commented 3 months ago

Setting this to Pending Release as GLTF previews are only available client side. Save As / Upload are covered here https://github.com/secondlife/viewer/issues/1638 and will verified again when a place outside the Develop menu is defined for these options.