search

secondlife / viewer

🖥️ Second Life's official client
GNU Lesser General Public License v2.1
209 stars 53 forks source link

GLTFOverrides creates ever-expanding vocache #1141

Open vir-linden opened 6 months ago

vir-linden commented 6 months ago

Environment

Any featurettes

Description

Beq Janus notes: In the current implementation of the vocache, the generic extras file has no extras support in killObject and has no pruning/delete functionality at all. As such, the overrides map just grows forever. Is working on a PR.

See details in the tpv slack channel.

Test Plan

Visit a region that uses many GLTF Overrides wait until the entire scene is loaded wander around for several minutes letting objects with overrides come into and out of your view and draw distance

Expected Behavior the .slec files found in the viewer's object cache should not be continuing to grow without bound

brad-linden commented 4 months ago

I believe this was fixed as part of PR #1230

vladyslavasproductengine commented 4 months ago

Deferred QA. Verified on the Second Life Release 7.1.8.9103842320 (64bit) on Win10/OSX in the scope of https://github.com/secondlife/iqa/issues/239. Could you please add a test plan?

brad-linden commented 4 months ago

@Dan-Linden I attempted to add a test plan to this one finally. could probably use additional set of eyes

Dan-Linden commented 4 months ago

I'm unable to reproduce the originally reported bug. I tested on the 7.1.4.8270899680 Featurettes viewer from https://releasenotes.secondlife.com/viewer/7.1.4.8270899680.html I also tested on RC 7.1.8.9375512768 - Materials Featurettes and don't see a problem there. I cannot guarantee it's fixed unless I can reproduce the original bug.

DmitrySProductengine commented 2 months ago

Deferred QA. Verified on the Second Life Release 7.1.9.10220184061 (64bit) on Win11/OSX in the scope of IQA #301.

Could you please suggest the region that uses many GLTF Overrides? Or clarify the test plan (maybe up to what number of files the limit is set, the cleaning principle, creation of objects with GLTF Overrides).

The viewer cache was cleared before verification. During verification, I tried to create many objects from the wiki example - https://wiki.secondlife.com/wiki/GLTF_Overrides. I also teleported to different regions known to me - but as a result, only 37 files (slc and slec) were created in the "objectcache" folder. I think that this number of cache files is still not enough to confirm the pass.