search

secondlife / viewer

🖥️ Second Life's official client
GNU Lesser General Public License v2.1
200 stars 47 forks source link

[Win] Fix windows window shutdown order #1252

Open akleshchev opened 2 months ago

akleshchev commented 2 months ago

Environment

Second Life Release 7.1.5.8443591509 (64bit)

Description

Window's viewer window shutdown process doesn't cleanup, window thread just dies without sending WM_DESTROY.

Reproduction steps

Login and then shutdown viewer. Check logs.

Logs shouldn't contain: 2024-04-16T23:57:46Z WARNING # llwindow/llwindowwin32.cpp(4575) LLWindowWin32::LLWindowWin32Thread::close : Closing window thread without using destroy_window_handler ... 2024-04-16T23:57:48Z WARNING # llwindow/llwindowwin32.cpp(4935) LLWindowWin32::LLWindowWin32Thread::wakeAndDestroy : Tried to close Queue. Win32 thread Queue already closed.

sergiiiproductengine commented 2 months ago

Passed QA.

Verified on the Second Life Release 7.1.7.8820704257 (64bit) on Win10 in the scope of https://github.com/secondlife/iqa/issues/211.