secondlife / viewer

🖥️ Second Life's official client
GNU Lesser General Public License v2.1
189 stars 43 forks source link

EmojiPicker inserts emoji to inactive chat floater when other modal floater is focused #1330

Open LLGuru opened 2 weeks ago

LLGuru commented 2 weeks ago

Environment

Second Life Release 7.1.6.8745209917 (64bit)

Description

When modal floater is shown, the emoji picker stays visible, and it is still possible to input emojis into the chat window The same problem is observed with opening top menus

Use-case A: EmojiPicker should be hidden when the modal (toast) floater is shown Use-case B: EmojiPicker should be hidden when the top menu is shown Use-case C: All menus should be hidden when the modal (toast) floater is shown

Reproduction steps

Use-case A

  1. Open chat floater
  2. Open Emoji Picker
  3. Try to close viewer Observe the message box "Are you sure you want to quit?"

image

Actual behavior:

Expected behavior:

Use-case B

  1. Open chat floater
  2. Open Emoji Picker
  3. Open any top menu

image

Actual behavior:

Expected behavior:

Use-case C

  1. Open any top menu
  2. Try to close viewer Observe the message box "Are you sure you want to quit?"

image

Actual behavior:

Expected behavior:

LLGuru commented 2 weeks ago

Fixed in https://github.com/secondlife/viewer/pull/1348