BOOL to bool conversion leftovers: ternaries

secondlife / viewer

🖥️ Second Life's official client

GNU Lesser General Public License v2.1

189 stars 43 forks source link

BOOL to bool conversion leftovers: ternaries #1333

Open marchcat opened 2 weeks ago

marchcat commented 2 weeks ago

After replacing the BOOL macros with the proper bool type, we still have multiple occurrences of now-redundant code involving ternary operations. For example:

void LLFloaterEmojiPicker::showPreview(bool show)
{
    //mPreview->setIcon(nullptr);
    mDummy->setVisible(show ? false : true);
    mPreview->setVisible(show ? true : false);
}

They should be updated to reflect the correct boolean type.

Test Plan

Non-testable. Build exists = accept.

LLGuru commented 5 days ago

Fixed in https://github.com/secondlife/viewer/pull/1416