search

secondlife / viewer

🖥️ Second Life's official client
GNU Lesser General Public License v2.1
189 stars 43 forks source link

Guru/viewer 1186 avatar load prioritization #1339

Open LLGuru opened 2 weeks ago

akleshchev commented 2 weeks ago

I like some of the changes (like the addition of initial status), but:

  1. It is going to conflict heavily with Maint A
  2. It has nothing to do with load prioritization, please don't use misleading names
  3. I strongly disagree with storing avatar rez status outside of avatar class ( ERezzedStatus should have stayed in avatar class, it is as a part of avatar's internal behavior). If you need to, you can move it to some common 'avatar constants' or something like that, notifications are not directly related to this status
  4. Please keep unrelated changes that seemingly do not affect functionality to a minimum it has been causing issues (ex: your cosmetic changes to LLToastNotifyPanel caused a crash).
akleshchev commented 2 weeks ago

Avatar load prioritization

Please fix commit's name, this commit has nothing to do with load prioritization.