search

secondlife / viewer

🖥️ Second Life's official client
GNU Lesser General Public License v2.1
199 stars 46 forks source link

GLTF terrain sometimes does not appear in mirrors #1353

Open Geenz opened 2 months ago

Geenz commented 2 months ago

Environment

Second Life Test 7.1.6.50023 (64bit) Release Notes Build Configuration RelWithDebInfo

You are at 90.0, 116.7, 26.8 in Rumpus Room 2048 located at simhost-01129fe6e38889eb3.aditi SLURL: secondlife://Aditi/secondlife/Rumpus%20Room%202048/90/117/27 (global coordinates 36,442.0, 14,196.7, 26.8) PMFP 2024-04-13.8669470587 Release Notes

Description

Every now and then GLTF material terrain does not show up in mirrors, resulting in a grey (possibly sky) patch being rendered instead. Non-GLTF material terrain is still visible. This bug appears to be intermittent.

Every now and then when the viewer is in this state, the terrain will occasionally "pop in" the mirror briefly (say, for a frame or two) then pop out.

Reproduction steps

  1. Go a mirror
  2. Zoom in so that the mirror probe activates
  3. If you're lucky, the mirror will not show the GLTF material terrain
cosmic-linden commented 2 weeks ago

I was unable to reproduce using some mirror test setups, and Rumpus Room 2048's framerate is too low. Going to explore Rumpus Room 2048's framerate issues: https://github.com/secondlife/viewer/issues/1761

cosmic-linden commented 2 weeks ago

I am now able to reproduce rarely in Rumpus Room 2048.

cosmic-linden commented 1 week ago

This isn't terrain-specific, but it sure is weird:

https://github.com/secondlife/viewer/issues/1833

^ Mirror probes will sometimes reflect void and nothing else, even when the facing direction seems correct.

cosmic-linden commented 1 week ago

I think I'm also seeing something weird with terrain rebuilds in mirrors - at one point I saw partial terrain flickering which was resolved by clicking Develop > Render Metadata > Octree.

So far, I've observed no anomalous mirror behavior which seems specific to PBR terrain.

cosmic-linden commented 1 week ago

I have decided to step away from this ticket because there is other related work on the queue which may mitigate the severity of this issue.