secondlife / viewer

🖥️ Second Life's official client
GNU Lesser General Public License v2.1
209 stars 54 forks source link

Mesh Upload - Physics - Bounding Box is not working as expected. #1418

Closed KrsityKu closed 1 month ago

KrsityKu commented 4 months ago

Environment

Second Life Release 7.1.6.8745209917 (64bit)

Description

When uploading a mesh, selecting Physics and Bound Box, should apply bounding box to all objects in the mesh, however, it only applies it to just one of them.

image

I don't know which version caused this change, but it worked around a year ago. (I don't upload meshes too often).

Official viewer and Firestorm Beta viewer have this issue. Alchemy viewer applies bounding box to all parts.

Reproduction steps

  1. Build -> Upload -> Model and use this file (or any model with multiple objects): TestSpheres.zip
  2. In the physics tab of the mesh uploader, pick Bounding Box
  3. Observe the preview - only the middle sphere has a bounding box and the log says: PHYS Model GeoSphere001Mesh loaded No physics model specified for GeoSphere003Mesh No physics model specified for GeoSphere002Mesh

Expected result - all 3 spheres should have their own bounding box.

kylelinden commented 4 months ago

Pulling into maint, does not need to stay in A. Devs choice.

LLGuru commented 4 months ago

Fixed in https://github.com/secondlife/viewer/pull/1467 image

valeriiaaproductengine commented 3 months ago

Passed QA.

Verified on the Second Life Release 7.1.9.9473057952 (64bit) on Win10/OSX in the scope of https://github.com/secondlife/iqa/issues/260.