secondlife / viewer

🖥️ Second Life's official client
GNU Lesser General Public License v2.1
200 stars 47 forks source link

(PBR) Moon clips with skydome #1445

Open canny[bot] opened 1 month ago

canny[bot] commented 1 month ago

The moon texture clips with skydome geometry, regardless of what the sky detail is set to in graphics preferences. If the sun is given the same texture, it does not clip.

Steps to reproduce:

1) Inventory->new settings->new sky. Edit the new sky.

1b) optional: set cloud density and coverage to maximum to see it easier, but it is noticeable as long as there are any clouds at all.

2) Move the sun and moon to the same azimuth and nearby elevations, I used 270 azimuth and 33 elevation for testing. The effect is worse at higher elevations.

3) Set the sun and moon to the same texture, for instance "moon" from the library.

4) Set sun scale to 10, moon scale to minimum. Move the camera around while viewing the sun; it does not flicker.

5) Set the moon scale to 10, sun scale to minimum, do the above; the moon flickers and clips against the skydome geometry. Changing the sky detail level in preferences changes the granularity of the flicker, but doesn't avoid it.

In the attached screenshot, top is the sun, bottom is the moon, moon has been set to 0 brightness. Elevations 45 and 30 respectively.

https://secondlife.canny.io/admin/board/bug-reports/p/pbr-moon-clips-with-skydome

canny[bot] commented 1 month ago

This issue has been linked to a Canny post: (PBR) Moon clips with skydome :tada:

AtlasLinden commented 1 month ago

Not to be confused with the old z-fighting of the sun and moon issue. This bug is only affecting the moon. Here's a fun recording of the moon at its highest elevation: https://gyazo.com/d5ee0af3820267e57ba125d10e6a7650 This reproduced on current default release Maint YZ 7.1.6.8745209917

Dan-Linden commented 1 month ago

Easy repro: Go to http://maps.secondlife.com/secondlife/Bug%20Island/227/134/26 and look at the sky to the North of you.

Image