[WebRTC] Add a warning that voice font's are no longer supported if user has voice fonts enabled.

roxanneskelly commented 4 months ago

Updated dialogue from UX and Product

Voice morphs are not supported by this viewer. For more information about other voice morph tools, see this article. [OK]

[ ] Don’t show me this again

Voice fonts are no longer supported in the WebRTC viewer (for the time being) If a user is using them, we need to pop up a warning. Also, UI to manage voice fonts needs to be removed.

UI placeholder

image (2)

Alternate dialogue suggestion: Voice Morphs are not supported by this viewer. You can either disable voice morphing and no longer see this dialog, or ignore this dialoge and continue this session without voice morphs. Labeled buttons: [Disable] [Ignore]

This will be the generic Voice FAQ link in FreshDesk: https://lindenlab.freshdesk.com/support/solutions/articles/31000173560-webrtc-update-for-voice-chat-faq/

Test Plan

Log in with the release viewer on a Vivox region.
Add a voice font (morphing) and enable it.
Log in with the WebRTC viewer.
Note that the UI to add/select voice fonts is no longer present.
Note that a warning pops up stating that voice fonts are no longer supported.
Log in with the release viewer.
Note that the voice font has been disabled.

igorlproductengine commented 2 months ago

Deferred QA. Verified on Second Life Release 7.1.9.9688089989 (64bit) in the scope of https://github.com/secondlife/iqa/issues/270 on Win10/OSX systems.

Test Environment: Grid: Aditi WebRTC Region: WebRTC1 Simulator: WebRTC-Voice 2024-06-24.9652733849 Voice Server Version: Secondlife WebRTC Gateway

Due to Voice Island being down on the Aditi grid, I am unable to verify the warning pop-up for unsupported voice fonts. However, I have confirmed that the UI for managing voice fonts has been successfully removed. As an alternative, I could attempt to verify this on the Agni grid by purchasing a voice morph for 750 $L on the Voice Island. Please advise if this is a suitable course of action.

roxanneskelly commented 2 months ago

We need to test on agni by purchasing a voice morph using the release (non-WebRTC) viewer, enabling it, and then relogging via the webrtc release candidate to verify there's a dialog that pops up that notifies the user that their voice morph won't be used.

Dan-Linden commented 2 months ago

Reopened. There was no warning pop up stating that voice fonts are no longer supported

Tested on Second Life Release 7.1.9.9688089989 (64bit) You are at 66.4, 40.3, 38.8 in Danger! Danger! located at simhost-0fd8f2ab7e7764e92.agni SLURL: http://maps.secondlife.com/secondlife/Danger%21%20Danger%21/66/40/39 (global coordinates 261,186.0, 249,640.0, 38.8) Second Life Server 2024-06-11.9458617693

kylelinden commented 1 month ago

@roxanneskelly copy for the dialogue has been completed. Went for the simplest solution for an issue that will only be awkward for ~2 weeks.

brad-linden commented 1 month ago

We need to test on agni by purchasing a voice morph using the release (non-WebRTC) viewer, enabling it, and then relogging via the webrtc release candidate to verify there's a dialog that pops up that notifies the user that their voice morph won't be used.

Can also be tested by opening debug settings at the login screen and setting VoiceMorphEnabled to true and VoiceEffectDefault to 'f0000000-0000-0000-0000-000000000000' (or any UUID other than the null UUID)

DmitrySProductengine commented 1 month ago

Failed QA. Verified on the Second Life Release 7.1.9.10084807842 (64bit) on Win10/OSX in the scope of IQA #293. The main feature (notification and disabling voice morphing) works correctly, but there are a couple of comments:

The link to FreshDesk opens a 404 page (perhaps such a page has not yet been created).
The notification does not have a correct description in the settings 'Always show/Never show' for notifications.

See attached screenshots:

Actual - 7.1.9.10084807842 - screenshot 1
Actual - 7.1.9.10084807842 - screenshot 2

AtlasLinden commented 1 month ago

Article has now been published. Page appears correctly upon clicking link in notification. Verified on 7.1.9.10084807842.

valeriiaaproductengine commented 1 month ago

Passed QA. Verified on the Second Life Release 7.1.9.10205353598 (64bit) on Win10/OSX in the scope of https://github.com/secondlife/iqa/issues/297. This issue was tested on Aditi- WebRTC, Vivox regions and on Agni Productengine region: secondlife://Aditi/secondlife/webRTC1/126/127/23 (WebRTC-Voice 2024-06-24.9652733849 ), secondlife://Aditi/secondlife/vivox1/48/70/23 (Second Life Server 2024-06-11.9458617693), http://maps.secondlife.com/secondlife/Product%20Engine/94/202/21.

secondlife / viewer