search

secondlife / viewer

🖥️ Second Life's official client
GNU Lesser General Public License v2.1
209 stars 53 forks source link

Server-side Translation UI - display translation in italics, below original text #1567

Open vir-linden opened 4 months ago

vir-linden commented 4 months ago

This work should be done in the projects/sst branch

Update server-side translation UI so that translated messages are shown below the source text. Attached image from steeltoe shows what this would look like (bottom left). For now, we are only implementing that one change from the image.

This change should apply to both nearby chat and IMs, both of which should be translated.

To access server-side translation, see the instructions in https://github.com/secondlife/viewer/issues/1244

Test Plan

See the linked image for illustration: image

LLGuru commented 4 months ago

Hi @steeltoelinden , @vir-linden

Whisper messages are being shown in italics The translation should also be shown in italics

As a result, whisper messages could look like translations, and vice versa image

("chuchote" is "whisper" in French)

Shouldn't we introduce any style difference between whisper messages and translations?

As an example, we could decrease the font size for translations image

LLGuru commented 4 months ago

Implemented in https://github.com/secondlife/viewer/pull/1606

Steeltoe-Linden commented 4 months ago

The translation is more important to the reader than the original utterance, so we would not make the translation smaller.

In real day-to-day use, there are many colors and styles that show up in chat, like chat repeaters, /me, inworld objects saying things in chat, other translators, and so on. We will never be able to come up with something entirely unique.

If there is a right-arrow character, we could put that in front of the italicized translation.

LLGuru commented 4 months ago

Hi @steeltoelinden

Thanks for the clarification

Does this icon look as expected? image

LLGuru commented 4 months ago