search

secondlife / viewer

🖥️ Second Life's official client
GNU Lesser General Public License v2.1
200 stars 47 forks source link

[Feature Request] add a prompt to confirm deleting the "New List" in Preferences->Auto-Replace settings #1595

Open valeriiaaproductengine opened 1 month ago

valeriiaaproductengine commented 1 month ago

Environment

Second Life Release 7.1.8.9103842320 (64bit) Release Notes

You are at 176.6, 70.7, 21.5 in Product Engine located at simhost-0d30785e85ea9fc12.agni SLURL: http://maps.secondlife.com/secondlife/Product%20Engine/177/71/21 (global coordinates 336,817.0, 307,271.0, 21.5) Second Life Server 2024-04-13.8669470296 Release Notes

CPU: 11th Gen Intel(R) Core(TM) i5-11260H @ 2.60GHz (2611.2 MHz) Memory: 16111 MB OS Version: Microsoft Windows 10 64-bit (Build 19045.4291) Graphics Card Vendor: NVIDIA Corporation Graphics Card: NVIDIA GeForce RTX 3050 Laptop GPU/PCIe/SSE2

Windows Graphics Driver Version: 31.0.15.2879 OpenGL Version: 4.6.0 NVIDIA 528.79

Window size: 1920x1001 Font Size Adjustment: 96pt UI Scaling: 1 Draw distance: 128m Bandwidth: 3000kbit/s LOD factor: 1.5 Render quality: 4 Texture memory: 4095MB Disk cache: Max size 1619.2 MB (0.4% used)

J2C Decoder Version: KDU v7.10.4 Audio Driver Version: FMOD Studio 2.02.20 Dullahan: 1.14.0.202310131404 CEF: 118.4.1+g3dd6078+chromium-118.0.5993.54 Chromium: 118.0.5993.54 LibVLC Version: 3.0.16 Voice Server Version: Vivox 4.10.0000.32327.5fc3fe7c.5942f08

Packets Lost: 44/88,933 (0.0%) May 30 2024 06:56:25

Description

If you need to delete a list, it is deleted instantly without a confirmation prompt in the Auto-Replace settings.

Location of the proposed Feature:

  1. Open the Viewer.
  2. Click "Me→Preferences→Chat tab".
  3. Click on the "Auto-Replace" button.
  4. Click on the "New list" button in the "Auto-Replace settings" floater.
  5. Give the name for the new list and click the "OK" button.
  6. Add couple replacements to the new list
  7. Select the newly crеated list and click the "Delete" button.

The list was instantly deleted. It would be appropriate to add a confirmation prompt like in the expected.png screenshot. (The prompt option may be different).

Expected.png screenshot:

actual

akleshchev commented 1 month ago

After checking for a bit, I decided that:

  1. There is no point confirming removal of empty lists since nothing of value gets lost and user still can cancel changes.
  2. Deleting a non-empty list should show that list isn't empty (aka, confirmation should show content count) in case user wasn't aware that list was large or something like that.

P.S. Might be a good idea to add a 'there are unsaved changes' when user hits cancel on the whole floater.

igorlproductengine commented 3 weeks ago

Passed QA.

Verified on the Second Life Release 7.1.9.9469671545 (64bit) on Win10/OSX in the scope of https://github.com/secondlife/iqa/issues/258.