secondlife / viewer

🖥️ Second Life's official client
GNU Lesser General Public License v2.1
209 stars 54 forks source link

Unable to Delete Links to worn objects in the Inventory window #1600

Open canny[bot] opened 4 months ago

canny[bot] commented 4 months ago

When attempting to delete a link to a worn object in the Inventory window is generating errors as if you were deleting the actual object being worn. This was observed in the outfits folder, but appears to affect links anywhere in inventory.

Messages are:

1) Some item(s) you wish to delete are being worn on your avatar. Remove these items from your avatar? (Option to Remove item(s) and delete or Cancel. Choosing Remove item(s) and delete will detach the object but only delete the link. The root object remains intact.) image

2) Some item(s) you wish to delete are required clothing layers (skin, shape, hair, eyes). You must replace those layers before deleting them. (No option other than to close error). image

Expected behavior is you should be able to delete a link regardless of whether the object is attached or not. Did not happen in previous viewer release.

Workaround: It's still possible to delete worn links in the Appearance window. We need the same functionality back in the Inventory window.

Here's the use case: A common use of the outfit system is to have a single outfit with your base look - hair, body, skin, eyes, etc - and then have secondary outfits with just clothes. The outfit system by default saves everything you're wearing so after creating the outfit you then go in to edit the outfit and remove the items that are in the base look. In that case you're just clearing out the links but you're wearing some of the items and don't want to have to switch out just to do basic maintenance. Advantages of setting up outfits like this include reduced clutter and the ability to set up several base looks with separate clothing outfits and mix and match as desired.

As for links in other locations, you might just be doing inventory maintenance and don't want to have to change shape/hairbase/eyes/skin or detach an item you're wearing just to clear out excess links that are no longer needed.

Being able to delete links without it affecting the linked object has been standard behavior for years and a lot of people leverage it.

Environment Second Life Release 7.1.7.8974243247 (64bit) Release Notes CPU: 12th Gen Intel(R) Core(TM) i9-12900K (3187.2 MHz) Memory: 65261 MB OS Version: Microsoft Windows 10/11 64-bit (Build 22631.3593) Graphics Card Vendor: NVIDIA Corporation Graphics Card: NVIDIA GeForce RTX 3080/PCIe/SSE2 Windows Graphics Driver Version: 31.0.15.4633 OpenGL Version: 4.6.0 NVIDIA 546.33 Window size: 3840x2054 Font Size Adjustment: 96pt UI Scaling: 1 Draw distance: 128m Bandwidth: 3000kbit/s LOD factor: 1.75 Render quality: 5 Texture memory: 9299MB Disk cache: Max size 1638.4 MB (22.3% used) J2C Decoder Version: KDU v7.10.4 Audio Driver Version: FMOD Studio 2.02.20 Dullahan: 1.14.0.202310131404 CEF: 118.4.1+g3dd6078+chromium-118.0.5993.54 Chromium: 118.0.5993.54 LibVLC Version: 3.0.16 Voice Server Version: Not Connected May 29 2024 06:42:44

https://secondlife.canny.io/admin/board/bug-reports/p/unable-to-delete-links-to-worn-objects

canny[bot] commented 4 months ago

This issue has been linked to a Canny post: Unable to Delete Links to worn objects :tada:

igorlproductengine commented 3 months ago

Passed QA.

Verified on the Second Life Release 7.1.9.9469671545 (64bit) on Win10/OSX in the scope of https://github.com/secondlife/iqa/issues/258.