secondlife / viewer

🖥️ Second Life's official client
GNU Lesser General Public License v2.1
212 stars 53 forks source link

On-water property lines persist at water level; do not line up properly with underwater land. #1644

Open WendiLinden opened 5 months ago

WendiLinden commented 5 months ago

Environment

Second Life Release 7.1.7.8974243247 (64bit) Release Notes

You are at 128.3, 129.6, 1,000.4 in Wendiland located at simhost-029942e1c53573a86.agni SLURL: http://maps.secondlife.com/secondlife/Wendiland/128/130/1000 (global coordinates 275,328.0, 286,338.0, 1,000.4) Second Life Server 2024-04-13.8669470296 Release Notes

CPU: 12th Gen Intel(R) Core(TM) i9-12900H (2918.41 MHz) Memory: 32459 MB OS Version: Microsoft Windows 10/11 64-bit (Build 22621.3593) Graphics Card Vendor: NVIDIA Corporation Graphics Card: NVIDIA GeForce RTX 3060 Laptop GPU/PCIe/SSE2

Windows Graphics Driver Version: 30.0.15.1215 OpenGL Version: 4.6.0 NVIDIA 512.15

Window size: 1888x928 Font Size Adjustment: 96pt UI Scaling: 1 Draw distance: 128m Bandwidth: 3000kbit/s LOD factor: 1.75 Render quality: 5 Texture memory: 5255MB Disk cache: Max size 1638.4 MB (100.0% used)

J2C Decoder Version: KDU v7.10.4 Audio Driver Version: FMOD Studio 2.02.20 Dullahan: 1.14.0.202310131404 CEF: 118.4.1+g3dd6078+chromium-118.0.5993.54 Chromium: 118.0.5993.54 LibVLC Version: 3.0.16 Voice Server Version: Vivox 4.10.0000.32327.5fc3fe7c.5942f08

Packets Lost: 15/257,235 (0.0%) June 05 2024 11:04:47

Description

This is, essentially, a follow-up to https://github.com/secondlife/jira-archive-internal/issues/70948 / SL-20578

While property lines do now show on the top of the water, they persist on top of the water when water is derendered from the Advanced menu. As a result, one cannot tell where the parcel line actually is on the land itself, causing a mismatch between the floating property line and the actual property location.

It would be nice if we could see the actual location of the property, though the water, and on the actual ground if water is derendered. Alternately, rolling back the change above would be a quick method of returning at least part of this functionality, as it is vital for the Land Product Team, and Residents, to be able to accurately work with inworld land.

Reproduction steps

  1. Be at a property over water.
  2. Turn property lines in the viewer using World > Show > Property Lines. parcel-line-01
  3. Derender water from Advanced > Rendering > Water Parcel-line-02
  4. Select ground with mouse and go into About Land parcel-line-03
  5. Observe the difference bwteen the floating property line and the actual property selection
kylelinden commented 5 months ago

Support needs to see property lines on terrain and/or water, not just water. Suggest a debug setting or render on terrain when water rendering is disabled.

LLGuru commented 5 months ago

Fixed in https://github.com/secondlife/viewer/pull/1794

igorlproductengine commented 1 month ago

Failed QA. Verified on the Second Life Release 7.1.11.10945332304 (64bit) on Win10/OSX in the scope of https://github.com/secondlife/iqa/issues/347.

Actual video:

https://github.com/user-attachments/assets/206f1d21-2228-4c0a-a2b2-a6ee9701ff55

LLGuru commented 1 month ago

Hi @kylelinden

Support needs to see property lines on terrain and/or water, not just water. Suggest a debug setting or render on terrain when water rendering is disabled.

This is already implemented Parcel lines are duplicated above water and underwater in case when "build" floater is visible or when the option "RenderHiddenSelections" is ON image

LLGuru commented 1 month ago

Normal rendering (both terrain and water) image

Rendering terrain without water image

Rendering water without terrain image

Shouldn't the parcel lines follow the water surface in the recent case?

guylinden commented 1 month ago

The property lines need to always show and be constant on the terrain. If there is water is over the terrain, the property lines are rendered on the water. We must frequently derender the water so that can properly subdivide and join the land that is in the water.

The problem is that when the water is derendered, the property line persists at water level. We can not longer see the property lines on the actual terrain. Due to the depth of the water, we can not effectively subdivide and join the parcels since the water property line and terrain are offset due to the depth.

We can see our yellow edit box while actually editing, but we can not edit the terrain by looking at offset property lines that are showing on the water.

With water derendered, you can move the camera below the water level, you can see the property lines on the terrain. These properly lines need to always be visible at any camera angle, if the water has been derendered.

AtlasLinden commented 1 month ago

@guylinden can you confirm if the behaviour illustrated in LLGuru's last comment is what you're after?

guylinden commented 1 month ago

The most recent example appears to be correct behavior.

While we never really derender the terrain while editing land, the property line should stay at the terrain level or completely gone, if the terrain is derendered and water is rendered.