search

secondlife / viewer

🖥️ Second Life's official client
GNU Lesser General Public License v2.1
200 stars 47 forks source link

Support control over rendering of Local Lights #1645

Open canny[bot] opened 1 month ago

canny[bot] commented 1 month ago

It is really desirable to be able to control local light rendering (whether they are editable of not) - for both performance and during photography. One can imagine a sophisticated (and complex) set of controls over local lights, but a simple first step is near.

The RenderLocalLightCount setting currently provides a means of control at the viewer.

Please expose RenderLocalLightCount on Advanced Graphics Settings.

Several criteria immediately present for the selection of local lights to be rendered when RenderLocalLightCount is set less than the number of placed local lights. Lights that are too far to illuminate any object at the camera focus are natural to cull; lights that are brightest at the camera focus are natural to render. The list should include any worn local lights.

The selection of lights to be rendered was recently changed. It seemed that lights closest to the camera were rendered first. While not ideal, this was far superior to the way it is now, where lights are rendered in an order seemingly unrelated to the position of the camera or its focus. I consider this last a bug, but I think exposing this control will be a super feature.

https://secondlife.canny.io/admin/board/feature-requests/p/support-control-over-rendering-of-local-lights

canny[bot] commented 1 month ago

This issue has been linked to a Canny post: Support control over rendering of Local Lights :tada:

akleshchev commented 3 weeks ago

Added new slider for lights into advanced graphical settings.

Suggesting test plan:

P.S. Lights furthest from you should vanish first. But if random lights instead of furthers vanish, create a but report, for me closests lights were prioritized.

vladyslavasproductengine commented 3 weeks ago

Fail QA. Verified on the Second Life Release 7.1.9.9469671545 (64bit) on Win10/OSX in the scope of secondlife/iqa#258. This feature is not implemented on this build yet.

sergiiiproductengine commented 2 weeks ago

Passed QA.

Verified on the Second Life Release 7.1.9.9473057952 (64bit) on Win10/OSX in the scope of https://github.com/secondlife/iqa/issues/260.

Note: Could you please clarify if light should be turned on next to camera zoom? eg: if there are 20 boxes with lights and the setting is turned on to 1 nearby light - than the nearest to camera light turns on following moving camera.

akleshchev commented 2 weeks ago

Could you please clarify if light should be turned on next to camera zoom? eg: if there are 20 boxes with lights and the setting is turned on to 1 nearby light - than the nearest to camera light turns on following moving camera.

I would argue that it should follow camera and looks like calcNearbyLights works based of camera.

P.S. This change doesn't change behavior, only exposes a pre-existing setting so if you think the way lights switch is buggy, please create a new ticket.

sergiiiproductengine commented 2 weeks ago

Could you please clarify if light should be turned on next to camera zoom? eg: if there are 20 boxes with lights and the setting is turned on to 1 nearby light - than the nearest to camera light turns on following moving camera.

I would argue that it should follow camera and looks like calcNearbyLights works based of camera.

P.S. This change doesn't change behavior, only exposes a pre-existing setting so if you think the way lights switch is buggy, please create a new ticket.

I think this behavior is acceptable, thanks.