search

secondlife / viewer

🖥️ Second Life's official client
GNU Lesser General Public License v2.1
200 stars 47 forks source link

Audit texture image unit usage on OS X #1736

Open RunitaiLinden opened 3 weeks ago

RunitaiLinden commented 3 weeks ago

Various crashes and bugs can be attributed to running out of texture image units. OpenGL guarantees we get at least 16, and OS X provides exactly that many and doesn't optimize out unused samplers (GLSL representation of texture image units).

Audit texture image unit usage on OS X and refactor shaders so that we don't rely on the shader compiler to optimize out unused samplers.

Test:

  1. Run viewer against old intel GPUs and intel macbooks.
  2. Enable shadows
  3. Verify transparent objects don't disappear
brad-linden commented 2 weeks ago

is this done? do we need a test plan?