search

secondlife / viewer

🖥️ Second Life's official client
GNU Lesser General Public License v2.1
206 stars 53 forks source link

A potential problem with the "WaterSign" shader uniform #1853

Open canny[bot] opened 2 months ago

canny[bot] commented 2 months ago

By enabling the developer debug console with debug level, i noticed the logs are spammed with this message : "Non-existing texture unit layer requested:" with a U32 value that corresponds to -1 as an S32 value after conversion to U32. (llrender.cpp)

Since this is spamming intensively i've been investigating, and i discovered this was due to a call to LLGLSLShader::getUniformLocation(const LLStaticHashedString& uniform).

So basically it can't locate the uniform. This mostly happens with the WaterSign uniform (lldrawpoolalpha.cpp) and seems to happen on windows or macos.

I'm not a specialist, and i didn't dig much further but i thought you might find this information useful.

Maybe this will help you figuring out some visual glitch, or point out some performance issue.

it also happens with noiseVec, ssao_irradiance_scale and ssao_irradiance_max but more sporadically. (those i think this is because the SSAO is disabled and those uniforms are present in the shader conditionally).

https://secondlife.canny.io/admin/board/bug-reports/p/a-potential-problem-with-the-watersign-shader-uniform

canny[bot] commented 2 months ago

This issue has been linked to a Canny post: A potential problem with the "WaterSign" shader uniform :tada: