search

secondlife / viewer

🖥️ Second Life's official client
GNU Lesser General Public License v2.1
211 stars 53 forks source link

The 'Set Empty' option does not remove previously applied keys for all control modes with the 'Apply to all' checkbox #1988

Closed sergiiiproductengine closed 1 month ago

sergiiiproductengine commented 3 months ago

Steps to reproduce:

  1. Login to the viewer.
  2. Go to Me > Preferences... > Controls.
  3. Change Primary Control, Alternate 1 or Alternate 2 next to 'Move Forward' action with checked 'Apply to all'.
  4. Click Primary Control, Alternate 1 or Alternate 2 that was applied in previous step.
  5. Check 'Apply to all' checkbox > Select 'Set Empty'.
  6. Observe changed action in all control modes.

Actual result: Selecting 'Set Empty' removes previously applied key just for current control mode and does not remove previously applied keys for all other control modes.

Expected result: Selecting “Set Empty” should remove any previously applied key and the control should be set to nothing for ALL control modes.

https://github.com/secondlife/viewer/assets/150452325/88727684-f842-40f0-92cb-f5adfba8493b

According to the Viewer Preferences Test Plan. Test case: 14. Controls - 14.2 Setting Controls - 3b.

Additional info: The issue is reproduced on Win10/OSX. The issue is reproduced on the current production build (7.1.8.9375512768).

Setting a new key is applied to all 4 control modes when 'Apply to all' checked. Also, selecting 'Default' changes the key to the given default for ALL control modes when 'Apply to all' checked as expected.

Environment

Second Life Release 7.1.9.9620320242 (64bit) Release Notes You are at 124.0, 83.6, 22.1 in Product Engine 2 located at simhost-0e311690c9759c6aa.agni SLURL: http://maps.secondlife.com/secondlife/Product%20Engine%202/124/84/22 (global coordinates 337,020.0, 307,284.0, 22.1) Second Life Server 2024-06-11.9458617693 Release Notes CPU: 11th Gen Intel(R) Core(TM) i7-11370H @ 3.30GHz (3302.39 MHz) Memory: 16076 MB OS Version: Microsoft Windows 10 64-bit (Build 19045.4651) Graphics Card Vendor: NVIDIA Corporation Graphics Card: NVIDIA GeForce RTX 3060 Laptop GPU/PCIe/SSE2 Windows Graphics Driver Version: 32.0.15.5612 OpenGL Version: 4.6.0 NVIDIA 556.12 Window size: 957x1017 Font Size Adjustment: 96pt UI Scaling: 1 Draw distance: 128m Bandwidth: 3000kbit/s LOD factor: 1.25 Render quality: 2 Texture memory: 5228MB Disk cache: Max size 1638.4 MB (0.1% used) J2C Decoder Version: KDU v7.10.4 Audio Driver Version: OpenAL, version 1.1 ALSOFT 1.23.1 / OpenAL Community / OpenAL Soft: OpenAL Soft Dullahan: 1.14.0.202310131404 CEF: 118.4.1+g3dd6078+chromium-118.0.5993.54 Chromium: 118.0.5993.54 LibVLC Version: 3.0.16 Voice Server Version: Vivox 4.10.0000.32327.5fc3fe7c.5942f08 Packets Lost: 0/1,787 (0.0%) July 11 2024 00:56:48

sergiiiproductengine commented 2 months ago

Passed QA.

Verified on the Second Life Release 7.1.10.10516785745 (64bit) on Win10/OSX in the scope of https://github.com/secondlife/iqa/issues/316.