Crash: LLViewerTextureList::updateImageDecodePriority(903)

[sl-service-account]

BugSplat Key Crash 92973

Sample Version: 7.1.9.10084807842

Sample Callstack:

SecondLifeViewer!LLViewerTextureList::updateImageDecodePriority	C:/a/viewer/viewer/indra/newview/llviewertexturelist.cpp(903)
SecondLifeViewer!LLViewerTextureList::updateImagesFetchTextures	C:/a/viewer/viewer/indra/newview/llviewertexturelist.cpp(1152)
SecondLifeViewer!LLViewerTextureList::updateImages	C:/a/viewer/viewer/indra/newview/llviewertexturelist.cpp(822)
SecondLifeViewer!display	C:/a/viewer/viewer/indra/newview/llviewerdisplay.cpp(814)
SecondLifeViewer!LLAppViewer::doFrame	C:/a/viewer/viewer/indra/newview/llappviewer.cpp(1514)
SecondLifeViewer!LLAppViewer::frame	C:/a/viewer/viewer/indra/newview/llappviewer.cpp(1347)
SecondLifeViewer!wWinMain	C:/a/viewer/viewer/indra/newview/llappviewerwin32.cpp(510)
SecondLifeViewer!invoke_main	D:/a/_work/1/s/src/vctools/crt/vcstartup/src/startup/exe_common.inl(118)
SecondLifeViewer!__scrt_common_main_seh	D:/a/_work/1/s/src/vctools/crt/vcstartup/src/startup/exe_common.inl(288)
kernel32!BaseThreadInitThunk
ntdll!RtlUserThreadStart

[akleshchev]

There are multiple different callstacks for this updateImageDecodePriority, but originally crashes were happening at if (face && face->getViewerObject() && face->getTextureEntry()) (current main) and once getTextureEntry() check got removed crashes moved to const LLTextureEntry* te = face->getTextureEntry();. Inside getTextureEntry() is an getTE call and it looks likely that getTE was called for a wrong index.

[vladyslavasproductengine]

Passed QA. Verified on the Second Life Release 7.1.10.10582490681 (64bit) on Win10/OSX in the scope of https://github.com/secondlife/iqa/issues/316.