search

secondlife / viewer

🖥️ Second Life's official client
GNU Lesser General Public License v2.1
209 stars 53 forks source link

BugSplat Crash: llwebrtc!rtc::webrtc_checks_impl::WriteFatalLog(88) #2321

Closed sl-service-account closed 1 month ago

sl-service-account commented 2 months ago

BugSplat Key Crash 95172

Sample Version: 7.1.9.10325451220

Sample Callstack:

llwebrtc!rtc::webrtc_checks_impl::WriteFatalLog./../../webrtc/webrtc/src/rtc_base/checks.cc(88)
llwebrtc!rtc::webrtc_checks_impl::WriteFatalLog./../../webrtc/webrtc/src/rtc_base/checks.cc(102)
llwebrtc!rtc::webrtc_checks_impl::FatalLog./../../webrtc/webrtc/src/rtc_base/checks.cc(197)
llwebrtc!rtc::webrtc_checks_impl::LogStreamer<>::Call./../../webrtc/webrtc/src/rtc_base/checks.h(313)
llwebrtc!rtc::webrtc_checks_impl::FatalLogCall<0>::operator&./../../webrtc/webrtc/src/rtc_base/checks.h(345)
llwebrtc!webrtc::AudioDeviceWindowsCore::DoCaptureThreadPollDMO./../../webrtc/webrtc/src/modules/audio_device/win/audio_device_core_win.cc(3032)
llwebrtc!webrtc::AudioDeviceWindowsCore::WSAPICaptureThreadPollDMO./../../webrtc/webrtc/src/modules/audio_device/win/audio_device_core_win.cc(2654)
kernel32!BaseThreadInitThunk
ntdll!RtlUserThreadStart
roxanneskelly commented 2 months ago

One of the bugsplat crashes is the result of a 0x88890008 error code from the internal windows audio subsystem, which is an issue that can happen when the audio device doesn't support the requested audio format (48khz, 1-2 channels, etc.)

dmytrohproductengine commented 1 month ago

Deferred QA. Verified on Verified on the Second Life Release 7.1.9.10479800881 (64bit) on Win10 in the scope of secondlife/iqa#311.

Could you provide a test plan, please?

I tried to upload the 48kHz audio file "piano2.wav" into the viewer and got the next error: upload_48kHz_audio Could you please clarify if is this expected?

piano2.wav https://www.kozco.com/tech/piano2.wav

roxanneskelly commented 1 month ago

audio upload is a separate issue than webrtc voice.

Dan-Linden commented 1 month ago

This can be verified by not seeing this crash in bugsplat in the new build when it's released.

vladyslavasproductengine commented 1 month ago

Passed QA.

Verified on the Second Life Release 7.1.9.10495892574 (64bit) on OSX/Win10 in the scope of https://github.com/secondlife/iqa/issues/312 Bugsplat: https://app.bugsplat.com/v2/crashes?c0=appVersion&f0=CONTAINS&v0=7.1.9.10495892574&database=SecondLife_Viewer_2018