search

secondlife / viewer

🖥️ Second Life's official client
GNU Lesser General Public License v2.1
211 stars 53 forks source link

Remove avatar rigging logging due to load time impact #2391

Open cosmic-linden opened 2 months ago

cosmic-linden commented 2 months ago

Description

LLScopedContextString debug code is present in avatar loading inner loop.

Tracy capture reveals a lot of time spent in LLPolySkeletalDistortion::apply during initial load in a region with many avatars. Further investigation shows that most of this time is spent in LLScopedContextString, a debug tool for Bento from 2016.

Test plan

These changes reduce debug logging related to avatars. Please inform the viewer team if these debug logging removals negatively impact testing.

Overall, this fix is very low-risk and no regressions are expected.

dmytrohproductengine commented 1 month ago

Deferred QA.

Verified on the Second Life Release 7.1.11.10947335521 (64bit) on Win10/OSX in the scope of https://github.com/secondlife/iqa/issues/348.

Need more info.

Could you provide a test plan, please?

cosmic-linden commented 1 month ago

@dmytrohproductengine Moved test plan from PR to issue per viewer project conventions.

dmytrohproductengine commented 1 month ago

@cosmic-linden, thanks for the clarification.

dmytrohproductengine commented 1 month ago

Passed QA.

Verified on the Second Life Release 7.1.11.10947335521 (64bit) on Win10/OSX in the scope of https://github.com/secondlife/iqa/issues/348.