search

secondlife / viewer

🖥️ Second Life's official client
GNU Lesser General Public License v2.1
206 stars 53 forks source link

Reset Skeleton issues #2403

Open canny[bot] opened 2 weeks ago

canny[bot] commented 2 weeks ago

Testing on the newest Atlasaurus build 7.1.9.10326512121 it appears the reset skeleton does not appear to be working as intended.

Wear an animation that changes bone position.

Remove/stop animation.

Note that doing Avatar>Reset Skeleton does not reset skeleton.

Doing right click on own Avatar then Reset Skeleton does reset skeleton.

Also introduced with I believe Maint-C was the ability for global reset where when you reset your skeleton, other people would received the reset command as well.

Tested with both people on the above Atlasaurus build this does not appear to be working where when you reset your skeleton from the right click menu, only your self resets. Others do not get the reset command.

https://secondlife.canny.io/admin/board/bug-reports/p/reset-skeleton-issues

canny[bot] commented 2 weeks ago

This issue has been linked to a Canny post: Reset Skeleton issues :tada:

LLGuru commented 2 weeks ago

Tested on tha same Atlasaurus build 7.1.9.10326512121

Used animation from the file animation bento_randomize_bones_and_attachments.anim Applied "Play Inworld" and "Play Locally" with no difference in the bug reproducion:

Top menu command "Avatar | Reset skeleton" doesn't restore the original sleleton Top menu command "Avatar | Reset skeleton and animations" restores the sleleton

Context menu command "Reset skeleton" doesn't restore the original sleleton Context menu command "Reset skeleton and animations" restores the sleleton

So the parity is observed between top menu commands and context menu commands

AtlasLinden commented 2 weeks ago

Here's the Maint C change mentioned in the original report: https://github.com/secondlife/jira-archive-internal/issues/86216

AtlasLinden commented 2 weeks ago

Also PR mentioned from reporter: https://github.com/secondlife/viewer/pull/2383

LLGuru commented 2 weeks ago

Thanks @AtlasLinden

So may we close this issue with resolution "Works as Expected"?

AtlasLinden commented 2 weeks ago

@LLGuru The following issues still appear to occur in the latest Maint C 7.1.9.9469671545 (which is rather old). Top menu command "Avatar | Reset skeleton" doesn't restore the original skeleton Context menu command "Reset skeleton" doesn't restore the original skeleton

Upon checking the changeset of that build, the above PR wasn't yet added to it. This will need to undergo testing once it's added to a new build.