search

secondlife / viewer

🖥️ Second Life's official client
GNU Lesser General Public License v2.1
211 stars 53 forks source link

Alert about expiring voice morphs needs to be removed from the viewer. #2413

Open Dan-Linden opened 2 months ago

Dan-Linden commented 2 months ago

Environment

Second Life Release 7.1.9.10515727195

Description

Alert about expiring voice morphs needs to be removed from the viewer.

Reproduction steps

  1. Log in with a user that has voice morphs which are about to expire.

Observe: A dialog pops up about the expiring Voice Morphs. image (4)

The first link is https://secondlife.com/destination/voice-island The second link is https://secondlife.com/destination/voice-morphing-premium

Here's a log from a different viewer, but this does reproduce in Atlasaurus+WebRTC 7.1.9.10515727195 SecondLife_VoiceMorphRenew.old.log

Expected: The voice morphs will be going away, so this alert should be removed.

akleshchev commented 2 months ago

Just expiring ones? Not expired ones?

igorlproductengine commented 1 month ago

Need more info. Verified on the Second Life Release 7.1.11.10947335521 (64bit) on Win10/OSX in the scope of https://github.com/secondlife/iqa/issues/348. The PE team is currently unable to test this issue, as we do not have access to an avatar with a Voice Morph subscription that is about to expire. Could you please:

  1. Provide an account with an expiring Voice Morph for testing purposes?
  2. Suggest an alternative way to trigger or simulate the expiring Voice Morph dialog event ?
Dan-Linden commented 1 month ago

Product says this does not need any further work right now.

I tested with my Testerd1 Tester account on Agni and saw VoiceEffectsWillExpire

Message in SecondLife.log: 2024-09-23T20:38:19Z WARNING # newview/lltoastalertpanel.cpp(197) LLToastAlertPanel::LLToastAlertPanel : Alert: Your version of Second Life does not know how to display the notification it just received. Please verify that you have the latest Viewer installed.\n\nError details: The notification called 'VoiceEffectsWillExpire' was not found in notifications.xml.

Second Life Release 7.1.11.10947335521 (64bit) You are at 67.7, 34.8, 38.5 in Danger! Danger! located at simhost-0dd7e33bcf6d85949.agni SLURL: http://maps.secondlife.com/secondlife/Danger%21%20Danger%21/68/35/39 (global coordinates 261,188.0, 249,635.0, 38.5) Second Life Server 2024-07-22.10048683488

akleshchev commented 1 month ago

I tested with my Testerd1 Tester account on Agni and saw

Looks like this notification can arrive from server.

akleshchev commented 1 month ago

During meeting it was decided that this should be reverted (partially?) utill server updates.

AtlasLinden commented 1 month ago

In a new Develop branch build, this notification appears on every startup. It also takes clicking OK 4 times to remove it (so it's possible it appears 4 times?)

Another request from the aforementioned meeting is to add a checkbox to remove this notification for next time.

akleshchev commented 1 month ago

https://github.com/secondlife/server/issues/1472

In a new Develop branch build, this notification appears on every startup.

  1. Restored the notification (but not the viewer side of code that triggers it). Apparantly server also can trigger it, so notification remains.
  2. Added 'don't show again' option
  3. Viewer side of notification is fully removed. Viewer should no longer show this by itself.
igorlproductengine commented 1 month ago

Need more info. Verified on the Second Life Release 7.1.11.11074622243 (64bit) on Win10/OSX in the scope of secondlife/iqa#356. The PE team is currently unable to test this issue, as we do not have access to an avatar with a Voice Morph subscription that is about to expire. Could you please:

  1. Provide an account with an expiring Voice Morph for testing purposes?
  2. Suggest an alternative way to trigger or simulate the expiring Voice Morph dialog event?
AtlasLinden commented 4 weeks ago

Verified this notification does not appear on ExtraFPS 7.1.11.11074622243 using the same account that triggered it on a Develop build. Further testing of the notification to be performed after implementation of https://github.com/secondlife/server/issues/1472.