secondlife / viewer

🖥️ Second Life's official client
GNU Lesser General Public License v2.1
212 stars 53 forks source link

Animated pbr textures don't animate #2768

Open canny[bot] opened 1 month ago

canny[bot] commented 1 month ago

Objects with an animated pbr textures stop animating the texture when we look elsewhere and back to the object.

A right click on the object triggers the animation again.

(a bit like the object not spinning as they should, a right click does the trick)

Happens on mac and pc

This doesn't happen if the material is not pbr.

https://secondlife.canny.io/admin/board/bug-reports/p/deltafps-extrafps-animated-pbr-textures-dont-animate

Test plan

canny[bot] commented 1 month ago

This issue has been linked to a Canny post: [deltaFPS] [extraFPS] Animated pbr textures don't animate :tada:

AtlasLinden commented 1 month ago

Reproduced on both DeltaFPS (7.1.10.10800445603) and ExtraFPS (7.1.11.11074622243) Clip of repro: https://gyazo.com/837144fbea9b84d5456bd3108a44f851

canny[bot] commented 1 month ago

This issue has been linked to a Canny post: Animated PBR textures using llSetTextureAnim appear randomly broken in the recent SL viewers :tada:

cosmic-linden commented 1 month ago

In my local dev build, I think I've fixed the part of this issue where the texture animations stops when looking away. However, the texture animation still sometimes fails to play on login. I will open a PR with the fix so far, and continue looking in to this ticket.

cosmic-linden commented 3 weeks ago

I've figured out the fix to PBR texture animations sometimes not starting. It turns out there was a texture animated object whose textures were contained solely in the GLTF overrides.