search

secondlife / viewer

🖥️ Second Life's official client
GNU Lesser General Public License v2.1
212 stars 53 forks source link

secondlife/viewer#2768: Fix for PBR texture animations sometimes not starting #3026

Closed cosmic-linden closed 2 weeks ago

cosmic-linden commented 2 weeks ago

Follow-up to https://github.com/secondlife/viewer/pull/2971 .

This fixes another case where PBR texture animations did not play, if the PBR base material does not contain textures but the GLTF material overrides do. The GLTF material overrides were arriving sufficiently late such that the texture virtual size was calculated to be 0, which prevented the texture matrix from being copied over to the LLDrawInfo. Since the contents of the overrides cannot be predicted in advance, a rebuild is required.

cosmic-linden commented 2 weeks ago

Based on my testing, this is a net improvement to texture animation behavior which fixes an observed bug.

cosmic-linden commented 2 weeks ago

Per our GitHub policies, the merging of this pull request locks the conversation. However, feedback is still welcome on these changes, provided that they are specific and actionable.