search

secondlife / viewer

🖥️ Second Life's official client
GNU Lesser General Public License v2.1
209 stars 53 forks source link

After setting material to Blank, cannot set the material to Default or None #789

Open Dan-Linden opened 8 months ago

Dan-Linden commented 8 months ago

Environment

Second Life Release 7.1.3.7821226606 (64bit) Release Notes

You are at 66.3, 40.2, 38.8 in Danger! Danger! located at simhost-0dce51b07a43a7deb.agni SLURL: http://maps.secondlife.com/secondlife/Danger%21%20Danger%21/66/40/39 (global coordinates 261,186.0, 249,640.0, 38.8) Second Life Server 2024-01-19.7590161929 Release Notes

CPU: AMD Ryzen 9 5980HX with Radeon Graphics (3293.82 MHz) Memory: 15775 MB OS Version: Microsoft Windows 10/11 64-bit (Build 22000.2538) Graphics Card Vendor: ATI Technologies Inc. Graphics Card: AMD Radeon RX 6800M

Windows Graphics Driver Version: 30.0.15020.1001 OpenGL Version: 4.6.14800 Core Profile Context 21.50.20.01 30.0.15020.1001

Window size: 1633x977 Font Size Adjustment: 96pt UI Scaling: 1 Draw distance: 128m Bandwidth: 3000kbit/s LOD factor: 1.75 Render quality: 5 Texture memory: 11474MB Disk cache: Max size 1638.4 MB (61.8% used)

J2C Decoder Version: KDU v7.10.4 Audio Driver Version: FMOD Studio 2.02.13 Dullahan: 1.14.0.202310131404 CEF: 118.4.1+g3dd6078+chromium-118.0.5993.54 Chromium: 118.0.5993.54 LibVLC Version: 3.0.16 Voice Server Version: Vivox 4.10.0000.32327.5fc3fe7c.399bd0e

Packets Lost: 9/17,701 (0.1%) February 09 2024 15:11:17

Description

After setting material to Blank, cannot set the material to Default or None

Reproduction steps

Repro 1.

  1. Edit a box and click the Textures tab
  2. Choose PBR Metallic Roughness from the Materials dropdown.
  3. Click the Choose from inventory button
  4. Click the "Blank" button in the Material picker. The object should turn grayish.
  5. Click the "Default" button.

Observed: The box remains gray. Expected: The box should revert to plywood.

Repro 2.

  1. Edit a box and click the Textures tab
  2. Choose PBR Metallic Roughness from the Materials dropdown.
  3. Click the Choose from inventory button
  4. Click the "Blank" button in the Material picker. The object should turn grayish.
  5. Click the "None" button.

Observed: The box remains gray. Expected: The box should revert to plywood.

Workaround to remove the Material:

LLGuru commented 8 months ago

Tested on the custom build, built from the recent branch release/gltf-maint2 The button "None" works the same way as the button "Default", just clears the effect set by the button "Blank" The expected behavior of the button Default is not known yet

@Dan-Linden, @AtlasLinden, could you please clarify this? Thanks

georgebproductengine commented 7 months ago

Failed QA. Verified on the Second Life Release 7.1.4.8149792635 (64bit) on Win10/OSX in the scope of https://github.com/secondlife/iqa/issues/150.

Dan-Linden commented 7 months ago

@LLGuru We have not defined a Default Material in the viewer. For now, the expected behavior when pressing the Default button in the Material picker is to remove the material. Pressing the None button in the Material picker should also remove the material.

The 7.1.3.7878383867 Emoji viewer can be referenced to see the correct behavior in action.

brad-linden commented 6 months ago

GLTF maint 2 has shipped, bumping back for triage

LLGuru commented 6 months ago

Observed the same behavior: GLTF-Maint-2 works identically to Maint-X

The "Blank" button clears the texture: light-gray for "Textures" and dark-gray for "PBR Metallic Roughness" The "Default" button returns the initial texture: plywood for both materials

Sending to QA

canny[bot] commented 6 months ago

This issue has been linked to a Canny post: PBR Editing - Unable to remove a Blank PBR material from object :tada: