secondlife / viewer

🖥️ Second Life's official client
GNU Lesser General Public License v2.1
199 stars 46 forks source link

BugSplat Crash: SecondLifeViewer!LLVertexBuffer::setBuffer(1377) #994

Open sl-service-account opened 3 months ago

sl-service-account commented 3 months ago

Test plan

  1. Set Debug setting "RenderMaxOpenGLVersion" = 3.2, set Graphics Quality = Low, and log in near a mirror.
  2. Verify the viewer does not crash.
  3. Set Debug setting "RenderMaxOpenGLVersion" = 3.2, set Graphics Quality = Low+, and log in near a mirror.
  4. Verify the viewer does not crash.
  5. Attempt to enable Mirrors in Advanced Graphics Preferences while GL=3.2.
  6. Verify that Mirrors do not become enabled and the viewer does not crash.

BugSplat Key Crash 91190

Notes: I set Debug setting "RenderMaxOpenGLVersion" = 3.2, Graphics Quality = Low, and logged in near a mirror.

Sample Version: 7.1.4.8270899680

Sample Callstack:

SecondLifeViewer!LLVertexBuffer::setBufferC:/a/viewer/viewer/indra/llrender/llvertexbuffer.cpp(1377)
SecondLifeViewer!LLHeroProbeManager::generateRadianceC:/a/viewer/viewer/indra/newview/llheroprobemanager.cpp(373)
SecondLifeViewer!LLHeroProbeManager::updateC:/a/viewer/viewer/indra/newview/llheroprobemanager.cpp(204)
SecondLifeViewer!displayC:/a/viewer/viewer/indra/newview/llviewerdisplay.cpp(664)
SecondLifeViewer!LLAppViewer::doFrameC:/a/viewer/viewer/indra/newview/llappviewer.cpp(1518)
SecondLifeViewer!LLAppViewer::frameC:/a/viewer/viewer/indra/newview/llappviewer.cpp(1351)
SecondLifeViewer!wWinMainC:/a/viewer/viewer/indra/newview/llappviewerwin32.cpp(510)
SecondLifeViewer!invoke_mainD:/a/_work/1/s/src/vctools/crt/vcstartup/src/startup/exe_common.inl(118)
SecondLifeViewer!__scrt_common_main_sehD:/a/_work/1/s/src/vctools/crt/vcstartup/src/startup/exe_common.inl(288)
kernel32!BaseThreadInitThunk
ntdll!RtlUserThreadStart
dmytrohproductengine commented 3 months ago

This issue is reproduced on Second Life Release 7.1.4.8270899680 (64bit) build on Win10 in the scope of secondlife/iqa/issues/160. Server: PMFP 2024-02-08.7835620080.

Bugsplat link: https://app.bugsplat.com/v2/keycrash?database=SecondLife_Viewer_2018&stackKeyId=91190

igorlproductengine commented 3 months ago

This issue is reproduced on Second Life Release 7.1.5.8472515256 (64bit) builds on Win10 in the scope of https://github.com/secondlife/iqa/issues/178. Server: PMFP 2024-03-29.8484451368.

Bugsplat link: https://app.bugsplat.com/v2/crash?database=SecondLife_Viewer_2018&id=1451435

kylelinden commented 1 month ago

Find out if it crashes with feature table on Low+ settings.

Dan-Linden commented 1 month ago

This does not crash on 7.1.7.9083069692 with Debug setting "RenderMaxOpenGLVersion" = 3.2 and the feature table (Graphics > Quality) on Low+ settings. While Debug setting "RenderMaxOpenGLVersion" = 3.2, changing the Graphics Quality slider, even to Ultra, does not Enable Mirrors in Advanced Graphics Preferences. If I deliberately enable Mirrors in Advanced Graphics Preferences while GL=3.2, then the viewer will crash.

sergiiiproductengine commented 1 week ago

Passed QA.

Verified on the Second Life Release 7.1.9.9620320242 (64bit) on Win10/OSX in the scope of https://github.com/secondlife/iqa/issues/266.

Notes:

I passed the issue because of no crash appears in all ways testing this issue, but:

win10 environment

CPU: 11th Gen Intel(R) Core(TM) i7-11370H @ 3.30GHz (3302.4 MHz) Memory: 16076 MB OS Version: Microsoft Windows 10 64-bit (Build 19045.4529) Graphics Card Vendor: NVIDIA Corporation Graphics Card: NVIDIA GeForce RTX 3060 Laptop GPU/PCIe/SSE2

So, could you please clarify which of these behaviours are expected and for wich unexpected behaviour the new issue(s) should be filled?