search

secondmind-labs / GPflux

Deep GPs built on top of TensorFlow/Keras and GPflow
https://secondmind-labs.github.io/GPflux/
Apache License 2.0
120 stars 24 forks source link

Update to newer GPflow and TensorFlow. #84

Closed jesnie closed 2 years ago

jesnie commented 2 years ago

Update to make GPflux compatible with newer versions of GPflow, that require an additional X parameter in the likelihoods. In this PR I just pass a dummy None value as X. Alternatively we could:

  1. I don't know Keras and GPflux well, but maybe we can find a "real" value of X to use?
  2. Do we want to attempt to write code that's compatible with earlier version of GPflow as well? I suppose we could add an if somewhere?
SebastianPopescu commented 2 years ago

all seems good from an initial view.