secondmind-labs / trieste

A Bayesian optimization toolbox built on TensorFlow
Apache License 2.0
217 stars 42 forks source link

Use tie breakers in Thompson sampling #757

Closed uri-granta closed 1 year ago

uri-granta commented 1 year ago

Investigating adding tie breakers to argmin as suggested in https://github.com/secondmind-labs/trieste/issues/464.

While this does work, the solution here has a significant performance impact as it requires a complicated transposition and shuffle of the entire array before calling tf.math.argmin. Suggest abandoning as not worthwhile.

hstojic commented 1 year ago

@uri-granta we can close this one, right?