secondmind-labs / trieste

A Bayesian optimization toolbox built on TensorFlow
Apache License 2.0
212 stars 42 forks source link

Search spaces should be deepcopied #776

Closed uri-granta closed 11 months ago

uri-granta commented 11 months ago

Related issue(s)/PRs: #104

Summary

Search spaces are currently not deepcopied for speed reasons (see #104). However, since there's nothing in the search space API that says spaces must be immutable this can result in bugs. It's also not clear how significant the speed saving is (saving state is not usually a bottleneck).

Fully backwards compatible: yes

PR checklist