secondmind-labs / trieste

A Bayesian optimization toolbox built on TensorFlow
Apache License 2.0
219 stars 42 forks source link

Batch trust regions should use latest query point #782

Closed khurram-ghani closed 7 months ago

khurram-ghani commented 1 year ago

Describe the bug The new batch trust region algorithms use the full dataset to determine the best point in each region. This is a hack, since the best point may have been queried by a different region in the previous iteration. Each region should only use its own query point from the previous iteration.

To reproduce Previous discussion on this issue is in this PR.

khurram-ghani commented 7 months ago

This was fixed in #788.