Investigate pylint and apply some of its suggestions. Also try running ruff.
The main thing holding us back from adopting pylint in CI is speed: running it on the codebase takes over a minute, compared to 3 seconds for flake8. If this PR exposes any concerning gaps then we could investigate whether there are any flake8 plugins that would cover them.
Ruff meanwhile is very fast but seems to catch less than flake8, so there is no incentive to switch.
Fully backwards compatible: yes
PR checklist
[x] The quality checks are all passing
[ ] The bug case / new feature is covered by tests
[ ] Any new features are well-documented (in docstrings or notebooks)
Related issue(s)/PRs:
Summary
Investigate pylint and apply some of its suggestions. Also try running ruff.
The main thing holding us back from adopting pylint in CI is speed: running it on the codebase takes over a minute, compared to 3 seconds for flake8. If this PR exposes any concerning gaps then we could investigate whether there are any flake8 plugins that would cover them.
Ruff meanwhile is very fast but seems to catch less than flake8, so there is no incentive to switch.
Fully backwards compatible: yes
PR checklist