secondmind-labs / trieste

A Bayesian optimization toolbox built on TensorFlow
Apache License 2.0
212 stars 41 forks source link

Make get_unique_points more efficient #809

Closed uri-granta closed 5 months ago

uri-granta commented 5 months ago

Related issue(s)/PRs: #781

Summary

Make get_unique_points more efficient and document its precise behaviour.

Fully backwards compatible: ish

The behaviour changes as we now use rounding to select points rather than a distance based loop. But the old behaviour was never fully documented, and the rounding approach should work fine for BatchTrustRegionBox.get_initialize_subspaces_mask which is the only place we currently use it.

PR checklist

uri-granta commented 5 months ago

Closing PR following offline discussion. Will create a separate PR for parallelising the existing greedy set cover algorithm.