secondmind-labs / trieste

A Bayesian optimization toolbox built on TensorFlow
Apache License 2.0
212 stars 41 forks source link

Make get_unique_points_mask more efficient #813

Closed uri-granta closed 5 months ago

uri-granta commented 5 months ago

Related issue(s)/PRs: #781

Summary

Make get_unique_points_mask run in parallel. Since this approach detects connected graph components, it can trip up on examples like [1,2,3,4] with tolerance 1, which should return two points not one, even though all the points are connected. However, we can fix this using what will almost certainly be a small number of iterations.

Fully backwards compatible: yes

PR checklist