secondmind-labs / trieste

A Bayesian optimization toolbox built on TensorFlow
Apache License 2.0
212 stars 41 forks source link

Don't save TR `ymin` from init dataset #843

Closed khurram-ghani closed 1 month ago

khurram-ghani commented 1 month ago

Related issue(s)/PRs: None

Summary

Tweaked TR initialization algorithm to not take the y_min value from the initial dataset, and instead leave it at inf. The previous version had the inconsistency that at initialisation the saved y_min value was not at the region center/location. This change means that the first update/step will always be successful.

Discussed and agreed this change with @vpicheny.

Fully backwards compatible: yes

PR checklist