search

secondstory / ofxDSHapVideoPlayer

ofxDSHapVideoPlayer is a Hap video player addon for openFrameworks (Windows-only)
Other
37 stars 21 forks source link

ofxDSHapVideoPlayer overwrites draw color #11

Closed Echolaitoc closed 7 years ago

Echolaitoc commented 7 years ago

The ofxDSHapVideoPlayer::draw(int x, int y, int w, int h) method has a hardcoded ofSetColor(255);. This makes it impossible to fade videos in and out, since the alpha is always set to full opacity. It also affects drawing after the ofxDSHapVideoPlayer, as there are no ofPushStyle() / ofPopStyle(). I'd suggest removing the ofSetColor and leaving it up to the user to set the draw color.

sheridanis commented 7 years ago

+1

mantissa commented 7 years ago

thanks for pointing that out (and for the +1), what bad practice :) it's fixed now