secretagentan / homework-responsive

0 stars 0 forks source link

feedback on assignment #7 #1

Open barryross opened 8 years ago

barryross commented 8 years ago

FEWD Week #7 Project: Responsive Design


Description

Relaxr's user count has grown, and the number of users accessing the site from a mobile device has surprised everyone, even by today's standards. The product managers at Relaxr have asked you to return to the project and make their site responsive so it renders nicely on mobile devices. They had one of their internal developers make a few tweaks to your source code, and they have given you the new HTML / CSS files to work from. Using these starter files, build out the mobile layouts for the landing page and blog.

Student: An Nguyen

Project URL: https://github.com/secretagentan/homework-responsive__

Technical Requirements Does Not Meet Expectations (0) Meets Expectations (1) Exceeds Expectations (2)
Use media queries at a 768px breakpoint x
Content remains in appropriate divs x
Content remains visible to the user x
Fonts change size appropriately x
Margins and padding change size appropriately x
Content does not overlap x
In the blog section, the two-column layout changes to a single-column layout when appropriate x
TOTAL: 14/14
barryross commented 8 years ago

Great work on this, An! You are doing a lot of things really well! Awesome job converting so many px-sized styles to em-based ones! One thing I noticed you could work on is to have the "about" section go full-width on smaller devices. I love seeing the fact that you are using a different sized fonts for the body, within your break point. That is excellent to see!

screen shot 2016-09-23 at 2 59 32 pm

(url)

barryross commented 8 years ago

and nice beginning on the mobile nav btw!