secretbis / tbcsim

A DPS simulator for World of Warcraft: The Burning Crusade
https://tbcsim.com
MIT License
25 stars 12 forks source link

Prot Warrior Phase 2 preset is for DPS warrior #129

Open flyingpiggs opened 2 years ago

flyingpiggs commented 2 years ago

Preset prot warrior for phase 2 seems to be some sort of DPS warrior based on gearing, consumes, and rotation, and I'm also unable to select the +40 stamina, +12 agility leg enchant.

secretbis commented 2 years ago

That was on purpose, as it was meant to simulate a warrior that is Prot spec, but not currently tanking. So, the output is a Devastate-based rotation, in full DPS gear with DPS consumables.

Incoming damage is very relevant to a Prot warrior that is currently tanking, and it's not very useful to simulate that without accounting for rage from damage taken. This requires some additional in-progress work to model that, along with parry-hasting, Enrage procs, and other effects of being attacked.