secretflow / heu

A high-performance homomorphic encryption algorithm library.
https://www.secretflow.org.cn/docs/heu/en/
Apache License 2.0
83 stars 39 forks source link

add iSHE algorithm to HEU #148

Closed Alec-xdu closed 2 weeks ago

Alec-xdu commented 1 month ago

add a kind of symmetric homomorphic encryption algorithm

github-actions[bot] commented 1 month ago

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

Alec-xdu commented 1 month ago

I have read the CLA Document and I hereby sign the CLA

usafchn commented 1 month ago

@Alec-xdu 请加一个 README 介绍一下算法,如果有相关 paper 也记到 readme 里面,感谢

Alec-xdu commented 1 month ago

好的 收到

usafchn commented 1 month ago

hi,我在 algorithm 下面建了个 incubator 文件夹,辛苦把整个 ishe 挪个位置吧,move 到 incubator/ https://github.com/secretflow/heu/tree/main/heu/algorithms/incubator

Alec-xdu commented 1 month ago

好的 以上问题正在修改,public key在文献中可以对应到keygen中生成的public parameters,作用是相似的

usafchn commented 1 month ago

好的 以上问题正在修改,public key在文献中可以对应到keygen中生成的public parameters,作用是相似的

可以把 PublicKey 重命名一下,让后 HeKit 整体引用

Alec-xdu commented 1 month ago

又看了一下test部分的源码,ut部分已经可以通过了

usafchn commented 3 weeks ago

稍等,这几天我会再看一下

usafchn commented 2 weeks ago

还有,我记得之前有个单测,为什么又删了。外层的统一测试覆盖不一定全,这里最好直接针对 iSHE 加一些测试

Alec-xdu commented 2 weeks ago

移文件夹的时候删掉了,刚才这个commit加回来

usafchn commented 2 weeks ago

@Alec-xdu 正文部分差不多了,UT 再加几个 case 覆盖一下就好了,感谢!

usafchn commented 2 weeks ago

已合入