Add missing replacements for valid envar generation

secrethub / secrethub-cli

A secrets management platform that every engineer can use with minimal code changes.

https://secrethub.io

Apache License 2.0

135 stars 23 forks source link

Closed edif2008 closed 4 years ago

edif2008 commented 4 years ago

Two characters that are in secrethub paths are not valid in envar naming: '.' and '-'. Now they will be replaced with '_'.

edif2008 commented 4 years ago

Indeed. I forgot to do that. Now it should be there.

SimonBarendse commented 4 years ago

@jpcoenen Do we want to create a hotfix release for this or include it in the next release? The --secrets-dir flag is already released in v0.41

jpcoenen commented 4 years ago

@jpcoenen Do we want to create a hotfix release for this or include it in the next release? The --secrets-dir flag is already released in v0.41

Yes, good point. Agreed. Especially since no other CLI release is planned soon. Can you manage that it gets released as a hotfix?