Add support for 1Password CLI 2 in the migration

secrethub / secrethub-cli

A secrets management platform that every engineer can use with minimal code changes.

https://secrethub.io

Apache License 2.0

135 stars 23 forks source link

Add support for 1Password CLI 2 in the migration #396

Closed edif2008 closed 2 years ago

edif2008 commented 2 years ago

Users who have the 1Password CLI 2 installed can now migrate from SecretHub to 1Password.

Note: When 1Password CLI 2 is used, it no longer adds the sign-in address in the 1password-migration-plan.yml file and it will not check whether the address coincides with the one the user is singed in.

hculea commented 2 years ago

Looks good, I've left a few suggestions. 👍

hculea commented 2 years ago

Code looks good to me 👍 I'll do some functional testing later today too.