secretkeylabs / sats-connect

Sats connect is a simple javascript library that connects apps to Bitcoin wallets
https://www.npmjs.com/package/sats-connect
88 stars 33 forks source link

Ledger - Sign Message hangs #106

Closed GiovaniGuizzoYUB closed 5 days ago

GiovaniGuizzoYUB commented 3 months ago

Using either request("signMessage", { ... }) or adapter.request("signMessage", { ... }) hangs with a ledger wallet connected. The promise is never resolved, even after confirming the signature on the ledger device.

AymericNoel commented 1 month ago

Hello, same happening here. Impossible to retrieve ledger signature....

teebszet commented 2 weeks ago

hi @GiovaniGuizzoYUB @AymericNoel , are you still experiencing the issue with the latest versions of sats-connect and Xverse chrome extension?

If so, do you have any more details on steps to reproduce this issue, or errors encountered?

thank you! 🙏

GiovaniGuizzoYUB commented 2 weeks ago

I have dropped sats-connect and wrote my own code, actually. Sorry I cannot help you with that anymore.

AymericNoel commented 2 weeks ago

Hi @teebszet, Still experiencing this error with last version of Xverse chrome extension (0.38.1) and Sats-connect (2.5.0).

Steps to reproduce:

m-aboelenein commented 2 weeks ago

Hi @teebszet, Still experiencing this error with last version of Xverse chrome extension (0.38.1) and Sats-connect (2.5.0).

Steps to reproduce:

  • install sats-connect with npm
  • install Xverse extension
  • Import ledger account on Xverse (bc1 address)
  • Connect wallet to website with :
 const providerResponse = await Wallet.request('getAccounts', {
          purposes: ['payment'],
          message: 'Address for signing in Ownership Tool'
        });
  • Sign with :
   const response = await Wallet.request("signMessage", {
              address: this.walletAddress,
              message: this.generatedPhrase,
            })
            signature = response.result.signature

We can see the request on the ledger device and sign but we never get response from this call. But this is working with not ledger accounts.

Hey @AymericNoel, we identified an issue specific to ledger on our end in the message signing request, the fix is already in the works and we are aiming to ship it soon, thanks for flagging this 🙏

teebszet commented 5 days ago

hi @AymericNoel this should be fixed from Xverse extension v0.39.0. thanks for reporting! 🙏