[bug] DAPP works on desktop but not on mobile xverse browser wallet

secretkeylabs / sats-connect

Sats connect is a simple javascript library that connects apps to Bitcoin wallets

https://www.npmjs.com/package/sats-connect

88 stars 33 forks source link

[bug] DAPP works on desktop but not on mobile xverse browser wallet #130

Closed elRaulito closed 1 month ago

elRaulito commented 2 months ago

Is there an existing issue for this?

[X] I have searched the existing issues

SATS-CONNECT Version

legacy

Current Behavior

I am able to connect on desktop and sign txs at the following dapp but cant' work on mobile xverse app wallet

Expected Behavior

It should work both on mobile and desktop

Steps To Reproduce

No response

Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)

No response

Anything else?

No response

elRaulito commented 2 months ago

https://claimoor.vercel.app/

This is the dapp in mainnet

fedeerbes commented 2 months ago

Hi @elRaulito. thanks for reporting this. Can you share the version of the mobile app and what packages are used in the dapp? sats-connect or sats-connect/core and their versions.

elRaulito commented 2 months ago

App version: Android 1.30.1 Dapp uses "sats-connect": "1.4.1",

elRaulito commented 2 months ago

@fedeerbes

fedeerbes commented 2 months ago

@elRaulito thanks. i'll take a look and let you know as soon as i have an answer.

fedeerbes commented 2 months ago

Hi @elRaulito, we found the root of the issue, our docs for signtransaction didn't reflect that payload.message is required and type string. Can you add that prop and let us know if this fixes the issue?

elRaulito commented 1 month ago

It works!