secretkeylabs / xverse-core

Core library for Xverse wallet
Other
39 stars 19 forks source link

Don't use dust UTXOs in txns #303

Closed victorkirov closed 1 year ago

victorkirov commented 1 year ago

πŸ”˜ PR Type

What kind of change does this PR introduce?

πŸ“œ Background

We were using confirmed Dust UTXOs as inputs for txns before unconfirmed large UTXOs (e.g. change).

Additionally, we weren't filtering out unconfirmed UTXOs when selecting them for inscription commit txns, so the fee estimate logic was using different logic to the final commit txn build logic causing inconsistencies.

πŸ”„ Changes

Does this PR introduce a breaking change?

Changes:

Impact:

βœ… Review checklist

Please ensure the following are true before merging:

github-actions[bot] commented 1 year ago

Test this PR with npm i --save-exact @secretkeylabs/xverse-core@4.1.0-b84b9a5