secretkeylabs / xverse-core

Core library for Xverse wallet

Other

39 stars 19 forks source link

refactor: move the applyFeeMultipliers function to core #335

Closed teebszet closed 11 months ago

teebszet commented 11 months ago

🔘 PR Type

[x] Refactoring (no functional changes, no api changes)
[x] Feature

📜 Background

https://linear.app/xverseapp/issue/ENG-3458/stx-fees-are-not-being-estimated

🔄 Changes

Does this PR introduce a breaking change?

[ ] Yes, Incompatible API changes
[x] No, Adds functionality (backwards compatible)
[ ] No, Bug fixes (backwards compatible)

Changes:

move the apply fee multiplier function to core after merging in changes from stx tx hex signing
add unit tests for fee multiplier/threshold logic

Impact:

stx token transfers will have fees capped at the thresholdHighStacksFees amount

🖼 Screenshot / 📹 Video

✅ Review checklist

Please ensure the following are true before merging:

[x] Code Style is consistent with the project guidelines.
[x] Code is readable and well-commented.
[x] No unnecessary or debugging code has been added.
[x] Security considerations have been taken into account.
[x] The change has been manually tested and works as expected.
[x] Breaking changes and their impacts have been considered and documented.
[x] Code does not introduce new technical debt or issues.

github-actions[bot] commented 11 months ago

Test this PR with npm i --save-exact @secretkeylabs/xverse-core@7.2.0-60f9ae5