secretkeylabs / xverse-core

Core library for Xverse wallet

Other

39 stars 19 forks source link

[ENG-3496] fix: utxo 500 issue add a fallback option to our api httpsbtc #339

Closed teebszet closed 10 months ago

teebszet commented 11 months ago

🔘 PR Type

[x] Enhancement

📜 Background

Issue Link: ENG-3496

🔄 Changes

Does this PR introduce a breaking change?

[ ] Yes, Incompatible API changes
[x] No, Adds functionality (backwards compatible)
[ ] No, Bug fixes (backwards compatible)

Changes:

Esplora API implementation has a fallbackUrl optional param, where if provided will:
- intercept 4xx or 5xx status codes and retry on fallback base url
- intercept timeouts and retry on fallback base url
behaviour is the same if fallbackUrl is not provided

Impact:

nothing until fallbackUrl is provided by the extension and mobile apps

🖼 Screenshot / 📹 Video

✅ Review checklist

Please ensure the following are true before merging:

[ ] Code Style is consistent with the project guidelines.
[ ] Code is readable and well-commented.
[ ] No unnecessary or debugging code has been added.
[ ] Security considerations have been taken into account.
[ ] The change has been manually tested and works as expected.
[ ] Breaking changes and their impacts have been considered and documented.
[ ] Code does not introduce new technical debt or issues.

github-actions[bot] commented 10 months ago

Test this PR with npm i --save-exact @secretkeylabs/xverse-core@7.2.0-31ce442